Seekra/frontend
3
3
Fork 0
generated from Seekra/repository-template
Code Issues 9 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

Feat(settings): settings configuration parser #78

Merged
jakob.scheid merged 20 commits from feature/settings-config-parser into main 2026-05-29 14:03:15 +02:00
Conversation 8 Commits 20 Files Changed 5
+256
johannes.vos commented 2026-05-26 11:39:57 +02:00
Member
Copy Link
Copy Source

Adds a JSON-based settings configuration parser. The config file lives at src/features/settings/settings.json and is loaded via dynamic import. A validator checks all entry types (bool, number, string, selection, section) and a Vue.js composable provides reactive access to the parsed configuration.

Related Issues

Closes: #77

Adds a JSON-based settings configuration parser. The config file lives at `src/features/settings/settings.json` and is loaded via dynamic import. A validator checks all entry types (bool, number, string, selection, section) and a Vue.js composable provides reactive access to the parsed configuration. # Related Issues Closes: #77
johannes.vos added this to the 0.1.0 milestone 2026-05-26 11:39:57 +02:00
johannes.vos added the
Priority
Medium
3
Area/SettingsKind/Feature labels 2026-05-26 11:39:57 +02:00
johannes.vos added this to the Project Board project 2026-05-26 11:39:57 +02:00
johannes.vos added 10 commits 2026-05-26 11:39:58 +02:00
add emty settingsConfig.js 878b558603
feat(settings): add JSDoc type definitions for settings config c387c1486f
add emty settingsValidator.js 0d7814d655
feat(settings): add settings config validator f6d72dbea3
add emtpy settingsParser.js d09514f71f
feat(settings): add settings config loader/parser e376e9b362
add emtpy useSettingsConfig.js 1378813783
feat(settings): add useSettingsConfig composable a165c13d7c
add emty public/settings.json 37ca0baa6d
feat(settings): add example settings.json to public/ aeb348fcfd
johannes.vos moved this to In progress in Project Board on 2026-05-26 11:40:04 +02:00
johannes.vos moved this to Review in Project Board on 2026-05-26 11:40:07 +02:00
jakob.scheid requested changes 2026-05-26 11:49:46 +02:00
Dismissed
jakob.scheid left a comment
Owner
Copy Link
Copy Source

Please do not put the settings file into public/ and do not load it via fetch. You should use a dynamic JavaScript import (await import('…')) and I ask you to put the settings into src/features/settings/settings.json or something similar.

Please do not put the settings file into `public/` and do not load it via `fetch`. You should use a dynamic JavaScript import (`await import('…')`) and I ask you to put the settings into `src/features/settings/settings.json` or something similar.
jakob.scheid commented 2026-05-26 11:52:48 +02:00
Owner
Copy Link
Copy Source

Please provide a description/summay of the PR.

Please provide a description/summay of the PR.
jakob.scheid commented 2026-05-26 11:58:19 +02:00
Owner
Copy Link
Copy Source

Why did you create the empty file public/settings.js?

Why did you create the empty file `public/settings.js`?
jakob.scheid requested changes 2026-05-26 12:01:28 +02:00
Dismissed
jakob.scheid left a comment
Owner
Copy Link
Copy Source

Can you please remove the example settings?

Can you please remove the example settings?
jakob.scheid reviewed 2026-05-26 12:09:22 +02:00
src/features/settings/utils/settingsValidator.js Outdated
@@ -0,0 +57,4 @@
assertString(entry.name, `${path}.name`);
assertString(entry.i18n, `${path}.i18n`);
if (entry.default === undefined) {
jakob.scheid commented 2026-05-26 12:09:22 +02:00
Owner
Copy Link
Copy Source

Not every setting does need a default value. I suggest omitting this check.

Not every setting does need a default value. I suggest omitting this check.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-26 12:11:06 +02:00
src/features/settings/utils/settingsValidator.js Outdated
@@ -0,0 +72,4 @@
}
if (entry.type === 'selection') {
validateSelectionOptions(entry.options, path);
if (typeof entry.allowMultiple !== 'boolean') {
jakob.scheid commented 2026-05-26 12:11:06 +02:00
Owner
Copy Link
Copy Source

I think it should have a default value (false) that is used if it is not specified.

I think it should have a default value (`false`) that is used if it is not specified.
jakob.scheid marked this conversation as resolved
jakob.scheid added 1 commit 2026-05-26 12:21:56 +02:00
feat(settings): Make setting default value optional 5d2064134b
jakob.scheid reviewed 2026-05-26 12:31:30 +02:00
src/features/settings/types/settingsConfig.js
@@ -0,0 +32,4 @@
* @property {string} [description]
*/
/**
jakob.scheid commented 2026-05-26 12:31:30 +02:00
Owner
Copy Link
Copy Source

Could you please check the value of type instead of the type of default?

Could you please check the value of `type` instead of the type of `default`?
jakob.scheid marked this conversation as resolved
johannes.vos added 5 commits 2026-05-26 14:55:22 +02:00
feat(settings): move settings.json to src and remove example content 462ae00506
feat(settings): replace fetch with dynamic import for settings.json 035aa1aa77
feat(settings): default allowMultiple to false if not specified 4ef6008976
feat(settings): use type field as discriminant in JSDoc type definitions 547bc241da
WIP da76d14d15
jakob.scheid added 1 commit 2026-05-26 19:51:46 +02:00
feat(settings): Make setting default value optional 34a7cb3f2c
jakob.scheid added 1 commit 2026-05-26 19:55:47 +02:00
feat(settings): Remove parameter 'url' from the loading function of the settings composable b47ab0355e
jakob.scheid added 1 commit 2026-05-26 19:57:39 +02:00
feat(settings): Remove old JSDoc typedefs 11800f6ef4
jakob.scheid approved these changes 2026-05-29 14:02:56 +02:00
jakob.scheid added 1 commit 2026-05-29 14:03:00 +02:00
Merge branch 'main' into feature/settings-config-parser b28af20d11
jakob.scheid merged commit 27a22ce569 into main 2026-05-29 14:03:15 +02:00
jakob.scheid deleted branch feature/settings-config-parser 2026-05-29 14:03:15 +02:00
jakob.scheid moved this to Done in Project Board on 2026-05-29 14:03:41 +02:00
jakob.scheid modified the milestone from 0.1.0 to settings-ready 2026-06-05 11:14:01 +02:00
jakob.scheid changed title from add settings configuration parser to Feat: settings configuration parser 2026-07-20 12:11:12 +02:00
jakob.scheid changed title from Feat: settings configuration parser to Feat(settings): settings configuration parser 2026-07-20 12:25:24 +02:00
jakob.scheid modified the milestone from settings-ready to 0.1.0 2026-07-22 11:33:11 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
Area/Global
A global issue or pull request
 Area/Search Results
An issue or pull requests related to the search results feature
 Area/Settings
The issue or pull request is related to the settings
 Area/Start page
Related to the start page
 Compat/Breaking
Breaking change that will not be backward compatible
 Kind/Bug
Something is not working
 Kind/Chore
Chore and maintainerance
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Refactor
Refactoring code
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Kind/Urgent
The issue or pull request is urgent
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Will Not Fix
3
This issue will not be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Area/Settings Kind/Feature
Priority
Medium
3
Milestone
No items
No Milestone 0.1.0
Projects
Clear projects
No projects
Project Board
Done
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes Vos)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#78