Seekra/frontend
3
3
Fork 0
generated from Seekra/repository-template
Code Issues 10 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

feat(settings): allow only sections as first-level settings

Browse Source
This commit is contained in:
jakob.scheid
2026-06-05 11:35:41 +02:00
parent a9f805e1fd
commit b729b85ad0
3 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/settings/utils/__tests__/settingsValidator.test.js
-9
View File
@@ -33,7 +33,6 @@ describe('validateSettingsConfig', () => {
{ raw: {
contents: [
{
type: 'section',
name: 'general',
i18n: 'settings.settings.general',
content: [
@@ -49,7 +48,6 @@ describe('validateSettingsConfig', () => {
{ raw: {
contents: [
{
type: 'section',
name: 'general',
i18n: 'settings.settings.general',
content: [
@@ -61,7 +59,6 @@ describe('validateSettingsConfig', () => {
]
},
{
type: 'section',
name: 'copyOfGeneral',
i18n: 'settings.settings.copyOfGeneral',
content: [
@@ -77,7 +74,6 @@ describe('validateSettingsConfig', () => {
{ raw: {
contents: [
{
type: 'section',
name: 'general',
i18n: 'settings.settings.general',
content: [
@@ -89,7 +85,6 @@ describe('validateSettingsConfig', () => {
]
},
{
type: 'section',
name: 'copyOfGeneral',
i18n: 'settings.settings.copyOfGeneral',
content: [
@@ -102,7 +97,6 @@ describe('validateSettingsConfig', () => {
]
},
{
type: 'section',
name: 'aSection',
i18n: 'settings.settings.aSection',
content: [
@@ -141,7 +135,6 @@ describe('validateSettingsConfig', () => {
{ raw: {
contents: [
{
type: 'section',
name: 'general',
i18n: 'settings.settings.general',
content: [
@@ -153,7 +146,6 @@ describe('validateSettingsConfig', () => {
]
},
{
type: 'section',
name: 'copyOfGeneral',
i18n: 'settings.settings.copyOfGeneral',
content: [
@@ -166,7 +158,6 @@ describe('validateSettingsConfig', () => {
]
},
{
type: 'section',
name: 'aSection',
i18n: 'settings.settings.aSection',
content: [
src/features/settings/utils/settingsValidator.js
+14 -1
View File
@@ -83,6 +83,19 @@ export const validateEntry = function validateEntry (entry, path) {
}
}
export const validateFirstLevelSection = function validateFirstLevelSection (section, path) {
assertString(section.name);
assertString(section.i18n);
if (!Array.isArray(section.content)) {
throw new Error(`[settings] "${path}.content" must be an array`);
};
section.content.forEach((entry, i) =>
validateEntry(entry, `${path}.content[${i}]`)
);
};
/**
* Validates a raw settings config object.
* @param {unknown} raw
@@ -97,7 +110,7 @@ export function validateSettingsConfig(raw) {
throw new Error('[settings] "contents" must be an array');
}
raw.contents.forEach((entry, i) =>
validateEntry(entry, `contents[${i}]`)
validateFirstLevelSection(entry, `contents[${i}]`)
);
return { valid: true, config: raw };
} catch (e) {